-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable MiMa #191
Enable MiMa #191
Conversation
What are the MiMa issues? We can usually ignore MiMa issues on Scala 3 since it doesn't automatically recognized package-privates. |
// we are checking binary compatibility from the 1.0.6 version | ||
mimaPreviousArtifacts ~= { | ||
_.filter { m => | ||
VersionNumber(m.revision).matchesSemVer(SemanticSelector(">=1.0.6")) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternately:
ThisBuild / tlVersionIntroduced := List("2.12", "2.13", "3").map(_ -> "1.0.6").toMap
@armanbilge It founds out that
I'm sure that we shouldn't add filters for those problems because we are enabling MiMa only from |
Yes, I agree we should not filter these issues. I was curious if there is any hope to fix them. Thanks for posting that. Actually, now I see those problems seem to be my fault in #104 😅 I'm not hopeful, but maybe it can be fixed. |
@armanbilge if I get it right, if we fix it, that would mean we will have binary issues with |
No, I think we may be able to fix it for everything :) |
Yeah, in theory, I may guess it so. But can we do it separately from this PR, WDYT? |
Nope, I was wrong. There's at least one method that is completely incompatible between 1.0.0-1.0.5 and 1.0.6-1.0.7. So somebody has to break.
👍 from me, this PR seems the right way forward. |
So, let's merge this and see what happens. If someone will have concerns about it - feel free to reconfigure MiMa as needed. |
Fixes #190.
There are many different binary compatibility issues, so I suggest just starting checking binary compatibility from the
1.0.6
version (the last released is1.0.7
). Any concerns about this?